Bug #76895 [Opn->Csd]: PHP-FPM7.x can't finish reloading after encountering a fatal error
Edit report at https://bugs.php.net/bug.php?id=76895&edit=1
ID: 76895
Updated by: bukka@php.net
Reported by: florisjan dot gerrits at gmail dot com
Summary: PHP-FPM7.x can't finish reloading after encountering
a fatal error
-Status: Open
+Status: Closed
Type: Bug
Package: FPM related
Operating System: Ubuntu 18.04 bionic
PHP Version: 7.2.10
-Assigned To:
+Assigned To: bukka
Block user comment: N
Private report: N
New Comment:
This issue should be fixed in 7.4. Please comment here or create a new bug report if you still see
it in 7.4.
Previous Comments:
------------------------------------------------------------------------
[2019-11-20 04:54:58] mnikulin at plesk dot com
Related To: Bug #77443
------------------------------------------------------------------------
[2019-10-22 07:36:24] mnikulin at plesk dot com
Related To: Bug #76601
------------------------------------------------------------------------
[2019-09-02 11:18:30] mnikulin at plesk dot com
Does not patch
https://github.com/php/php-src/pull/4461
that is included in PHP-7.2.22 and PHP-7.3.9
fixes the problem? Just surprised that the bug
was not mentioned in the release notes. Are there
any complications?
------------------------------------------------------------------------
[2019-07-23 08:14:32] nikic@php.net
It does look like opcache is being rather overzealous with signal blocking in one instance: https://github.com/php/php-src/blob/cef2071eb4298c50983b6a650d615857609f1fb4/ext/opcache/ZendAccelerator.c#L2031
This blocks interruptions during the compile_file call below and if that causes a bailout, I believe
we will never unblock interrupts.
We have a sanity check for non-zero signal depth on shutdown in https://github.com/php/php-src/blob/cef2071eb4298c50983b6a650d615857609f1fb4/Zend/zend_signal.c#L342,
but apparently the zend_signal_deactive() function is never actually used...
------------------------------------------------------------------------
[2019-02-20 04:05:04] mnikulin at plesk dot com
To reproduce the problem opcache.so must be loaded.
See the comment added at 2019-02-20 03:59 UTC to Bug #76601
for an unfinished attempt to write a test for this bug.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=76895
--
Edit this bug report at https://bugs.php.net/bug.php?id=76895&edit=1
Thread (8 messages)