Bug #76895 [Opn]: PHP-FPM7.x can't finish reloading after encountering a fatal error
Edit report at https://bugs.php.net/bug.php?id=76895&edit=1
ID: 76895
Updated by: nikic@php.net
Reported by: florisjan dot gerrits at gmail dot com
Summary: PHP-FPM7.x can't finish reloading after encountering
a fatal error
Status: Open
Type: Bug
Package: FPM related
Operating System: Ubuntu 18.04 bionic
PHP Version: 7.2.10
Block user comment: N
Private report: N
New Comment:
It does look like opcache is being rather overzealous with signal blocking in one instance: https://github.com/php/php-src/blob/cef2071eb4298c50983b6a650d615857609f1fb4/ext/opcache/ZendAccelerator.c#L2031
This blocks interruptions during the compile_file call below and if that causes a bailout, I believe
we will never unblock interrupts.
We have a sanity check for non-zero signal depth on shutdown in https://github.com/php/php-src/blob/cef2071eb4298c50983b6a650d615857609f1fb4/Zend/zend_signal.c#L342,
but apparently the zend_signal_deactive() function is never actually used...
Previous Comments:
------------------------------------------------------------------------
[2019-02-20 04:05:04] mnikulin at plesk dot com
To reproduce the problem opcache.so must be loaded.
See the comment added at 2019-02-20 03:59 UTC to Bug #76601
for an unfinished attempt to write a test for this bug.
------------------------------------------------------------------------
[2019-02-20 03:59:57] mnikulin at plesk dot com
Related To: Bug #76601
------------------------------------------------------------------------
[2019-02-04 09:44:10] mnikulin at plesk dot com
Related To: Bug #76601
------------------------------------------------------------------------
[2019-01-24 03:18:18] mnikulin at plesk dot com
Related To: Bug #77140
------------------------------------------------------------------------
[2019-01-23 08:20:05] emayoral at arsys dot es
Will not let me vote on the issue, but I am also affected. (https://bugs.php.net/bug.php?id=77443)
Patch suggested by mnikulin at plesk dot com would help , any plans to incorporate the patch at
least in php 7.1 and upwards?
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=76895
--
Edit this bug report at https://bugs.php.net/bug.php?id=76895&edit=1
Thread (8 messages)