ID: 17098
Updated by: yohgaki@php.net
Reported By: pmoor@netpeople.ch
Status: Open
Bug Type: Apache2 related
Operating System: linux
PHP Version: 4.0CVS-2002-10-17
New Comment:
It would be Apache2 bug
------------
On October 17, 2002 07:06 pm, Yasuo Ohgaki wrote:
> Andrei Zmievski wrote:
> > Hi,
> >
> > We have 10 critical bugs in the list currently. If you could please
see
> > about fixing at least one of them, we'd be that much closer to a
release
> > candidate.
>
> Summary: Apache2 sending 304 - not modified header
> http://bugs.php.net/bug.php?id=17098
>
> This is serious problem for serious sites.
> (Serious sites shouldn't use Apache2, though)
This looks like an Apache 2 bug, rather then aPHP one. I am guessing
the fix
they made did not work properly.
Ilia
Previous Comments:
------------------------------------------------------------------------
[2002-10-17 17:54:43] yohgaki@php.net
Although, we need other patch, it seems the problem exists.
------------------------------------------------------------------------
[2002-10-14 11:00:55] rt@takagi-ryo.ac
This is still not fixed... PHP code needs modifying.
I have tried PHP 4.2.3 and 4.3.0-pre1 with Apache 2.0.43
running on RedHat 6.2, and it still returns erroneous 304s.
The following is what I 'borrowed' from the Apache's
mod_include.c, which seems working within PHP 4.2.3.
--- sapi/apache2filter/sapi_apache2.c~ Fri Aug 16 07:27:03 2002
+++ sapi/apache2filter/sapi_apache2.c Mon Oct 14 23:27:26 2002
@@ -558,14 +558,24 @@
return OK;
}
+static int includes_setup(ap_filter_t *f)
+{
+ /* We will ALWAYS set the no_local_copy value to 1 so
+ * that we will not send 304s.
+ */
+ f->r->no_local_copy = 1;
+
+ return OK;
+}
+
static void php_register_hook(apr_pool_t *p)
{
ap_hook_pre_config(php_pre_config, NULL, NULL,
APR_HOOK_MIDDLE);
ap_hook_post_config(php_apache_server_startup, NULL, NULL,
APR_HOOK_MIDDLE);
ap_hook_insert_filter(php_insert_filter, NULL, NULL,
APR_HOOK_MIDDLE);
ap_hook_post_read_request(php_post_read_request, NULL, NULL,
APR_HOOK_MIDDLE);
- ap_register_output_filter("PHP", php_output_filter, NULL,
AP_FTYPE_RESOURCE);
- ap_register_input_filter("PHP", php_input_filter, NULL,
AP_FTYPE_RESOURCE);
+ ap_register_output_filter("PHP", php_output_filter,
includes_setup, AP_FTYPE_RESOURCE);
+ ap_register_input_filter("PHP", php_input_filter,
includes_setup, AP_FTYPE_RESOURCE);
}
AP_MODULE_DECLARE_DATA module php4_module = {
------------------------------------------------------------------------
[2002-09-30 20:24:19] iliaa@php.net
Sorry, but the bug system is not the appropriate forum for asking
support questions. Your problem does not imply a bug in PHP itself.
For a list of more appropriate places to ask for help using PHP,
please visit http://www.php.net/support.php
Thank you for your interest in PHP.
This is an Apache 2 bug.
According to http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9673
this bug has been corrected in Apache 2.0.42 and later.
------------------------------------------------------------------------
[2002-08-16 03:56:57] markonen@php.net
Sir, you are correct in your analysis.
------------------------------------------------------------------------
[2002-08-15 13:30:40] duke@mastre.com
3+ months later and this still happens with Apache 2.0.40 and PHP
snapshot php4-200208150600 !!! Seems that PHP developers view Apache2
as pre-alpha and they don't want to touch it with a 10-foot stick.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/17098
--
Edit this bug report at http://bugs.php.net/?id=17098&edit=1