#17098 [Csd]: apache sending 304 - not modified header

ID: 17098 Updated by: derick@php.net Reported By: pmoor@netpeople.ch Status: Closed Bug Type: Apache2 related Operating System: linux PHP Version: 4.0CVS-2002-10-17 New Comment: Try a NON stable snapshot, it's fixed in CVS> Derick Previous Comments: ------------------------------------------------------------------------ [2002-12-29 15:51:59] dk@webcluster.at Isn't fixed in php4-STABLE-200212290030 Daniel [datenPUNK] Khan ------------------------------------------------------------------------ [2002-12-27 14:13:19] iliaa@php.net This bug has been fixed in CVS. In case this was a PHP problem, snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. In case this was a documentation problem, the fix will show up soon at http://www.php.net/manual/. In case this was a PHP.net website problem, the change will show up on the PHP.net site and on the mirror sites in short time. Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ [2002-12-27 13:55:15] daniel.eckl@gmx.de ... and the bug is present in 4.3.0 release. ------------------------------------------------------------------------ [2002-12-25 18:03:55] daniel.eckl@gmx.de ... and it's not fixed in 4.3.0 RC4 either... Daniel ------------------------------------------------------------------------ [2002-12-13 18:24:22] daniel.eckl@gmx.de This bug is _NOT_ fixed in 4.3.0 rc3! In 4.3.0, the apache2 support should not be experimental anymore, so I think, this is a real showstopper IMHO. I think, it's time to fix this issue now, it's so annoying and unneccessary. If this patch has any known drawbacks that I'm not aware of, then it's NOT the correct solution to simply ignore this subject as whole. Daniel Here is the patch again as diff against php 4.3.0 rc 3: --- sapi/apache2filter/sapi_apache2.c.old Thu Dec 12 21:48:58 2002 +++ sapi/apache2filter/sapi_apache2.c Thu Dec 12 21:50:43 2002 @@ -619,14 +619,24 @@ return OK; } +static int includes_setup(ap_filter_t *f) +{ + /* We will ALWAYS set the no_local_copy value to 1 so + * that we will not send 304s. + */ + f->r->no_local_copy = 1; + + return OK; +} + static void php_register_hook(apr_pool_t *p) { ap_hook_pre_config(php_pre_config, NULL, NULL, APR_HOOK_MIDDLE); ap_hook_post_config(php_apache_server_startup, NULL, NULL, APR_HOOK_MIDDLE); ap_hook_insert_filter(php_insert_filter, NULL, NULL, APR_HOOK_MIDDLE); ap_hook_post_read_request(php_post_read_request, NULL, NULL, APR_HOOK_MIDDLE); - ap_register_output_filter("PHP", php_output_filter, NULL, AP_FTYPE_RESOURCE); - ap_register_input_filter("PHP", php_input_filter, NULL, AP_FTYPE_RESOURCE); + ap_register_output_filter("PHP", php_output_filter, includes_setup, AP_FTYPE_RESOURCE); + ap_register_input_filter("PHP", php_input_filter, includes_setup, AP_FTYPE_RESOURCE); } AP_MODULE_DECLARE_DATA module php4_module = { ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/17098 -- Edit this bug report at http://bugs.php.net/?id=17098&edit=1