Bug #80648 [NEW]: Fix for bug #79296 should be based on runtime libzip version

From: Date: Tue, 19 Jan 2021 20:41:34 +0000
Subject: Bug #80648 [NEW]: Fix for bug #79296 should be based on runtime libzip version
Groups: php.bugs 
Request: Send a blank email to php-bugs+get-231658@lists.php.net to get a copy of this message 
From:             arnoutboks at gmail dot com
Operating system: Linux
PHP version:      7.4.14
Package:          Zip Related
Bug Type:         Bug
Bug description:Fix for bug #79296 should be based on runtime libzip version

Description:
------------
In https://github.com/php/php-src/pull/5281,
a fix/BC workaround for bug
#79296 was added. This fix checks compile-time if an affected version of
libzip (>= 1.6) is used and uses that to determine if the BC workaround
is necessary.

However, if PHP is compiled with e.g. libzip 1.5.1 but dynamically
linked to e.g. libzip 1.7.3 at runtime, the BC workaround is not applied
and bug #79296 still occurs. This happens e.g. when using the PHP
packages from deb.sury.org (see also
https://github.com/oerdnj/deb.sury.org/issues/1521).


It would probably be better to not do the libzip version check at
compile-time based on the headers, but runtime based on
zip_libzip_version().


-- 
Edit bug report at https://bugs.php.net/bug.php?id=80648&edit=1
-- 
Fix committed:                    https://bugs.php.net/fix.php?id=80648&r=fixed
Fixed in release:                 https://bugs.php.net/fix.php?id=80648&r=alreadyfixed
Need backtrace:                   https://bugs.php.net/fix.php?id=80648&r=needtrace
Need Reproduce Script:            https://bugs.php.net/fix.php?id=80648&r=needscript
Try newer version:                https://bugs.php.net/fix.php?id=80648&r=oldversion
Not developer issue:              https://bugs.php.net/fix.php?id=80648&r=support
Expected behavior:                https://bugs.php.net/fix.php?id=80648&r=notwrong
Not enough info:                  https://bugs.php.net/fix.php?id=80648&r=notenoughinfo
Submitted twice:                  https://bugs.php.net/fix.php?id=80648&r=submittedtwice
register_globals:                 https://bugs.php.net/fix.php?id=80648&r=globals
PHP version support discontinued: https://bugs.php.net/fix.php?id=80648&r=phptooold
Daylight Savings:                 https://bugs.php.net/fix.php?id=80648&r=dst
IIS Stability:                    https://bugs.php.net/fix.php?id=80648&r=isapi
Install GNU Sed:                  https://bugs.php.net/fix.php?id=80648&r=gnused
Floating point limitations:       https://bugs.php.net/fix.php?id=80648&r=float
No Zend Extensions:               https://bugs.php.net/fix.php?id=80648&r=nozend
MySQL Configuration Error:        https://bugs.php.net/fix.php?id=80648&r=mysqlcfg

Thread (5 messages)

« previous php.bugs (#231658) next »