Bug #80648 [PATCH]: Fix for bug #79296 should be based on runtime libzip version

Edit report at https://bugs.php.net/bug.php?id=80648&edit=1 ID: 80648 Patch added by: Rahulsainilavi95@gmail.com Reported by: arnoutboks at gmail dot com Summary: Fix for bug #79296 should be based on runtime libzip version Status: Closed Type: Bug Package: Zip Related Operating System: Linux PHP Version: 7.4.14 Assigned To: cmb Block user comment: N Private report: N New Comment: The following pull request has been associated: Patch Name: Replace http:// to https:// On GitHub: https://github.com/php/web-php/pull/287 Patch: https://github.com/php/web-php/pull/287.patch Previous Comments: ------------------------------------------------------------------------ [2021-01-20 15:26:09] cmb@php.net Automatic comment on behalf of cmbecker69@gmx.de Revision: http://git.php.net/?p=php-src.git;a=commit;h=6adfb8c9621578c7ebb84091695d6cdc65cc0634 Log: Fix #80648: Fix for bug 79296 should be based on runtime version ------------------------------------------------------------------------ [2021-01-20 13:23:56] cmb@php.net The following pull request has been associated: Patch Name: Fix #80648: Fix for bug 79296 should be based on runtime version On GitHub: https://github.com/php/php-src/pull/6625 Patch: https://github.com/php/php-src/pull/6625.patch ------------------------------------------------------------------------ [2021-01-19 20:41:34] arnoutboks at gmail dot com Description: ------------ In https://github.com/php/php-src/pull/5281, a fix/BC workaround for bug #79296 was added. This fix checks compile-time if an affected version of libzip (>= 1.6) is used and uses that to determine if the BC workaround is necessary. However, if PHP is compiled with e.g. libzip 1.5.1 but dynamically linked to e.g. libzip 1.7.3 at runtime, the BC workaround is not applied and bug #79296 still occurs. This happens e.g. when using the PHP packages from deb.sury.org (see also https://github.com/oerdnj/deb.sury.org/issues/1521). It would probably be better to not do the libzip version check at compile-time based on the headers, but runtime based on zip_libzip_version(). ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=80648&edit=1