Bug #68861 [Opn->Ver]: chown does not work when php is compiling with ZTS

Edit report at https://bugs.php.net/bug.php?id=68861&edit=1 ID: 68861 Updated by: cmb@php.net Reported by: lg at efficientip dot com Summary: chown does not work when php is compiling with ZTS -Status: Open +Status: Verified Type: Bug Package: Filesystem function related Operating System: FreeBSD PHP Version: 5.6.4 Block user comment: N Private report: N New Comment: That patch doesn't look quite right. POSIX mandates[1]: | If name is an invalid value, sysconf() shall return -1 and set | errno to indicate the error. If the variable corresponding to name | is described in <limits.h> as a maximum or minimum value and the | variable has no limit, sysconf() shall return -1 without changing | the value of errno. So errno needs to be inspected at least. If anybody is interested in having this fixed, please provide a pull request[2]. [1] <https://pubs.opengroup.org/onlinepubs/9699919799/functions/sysconf.html> [2] <https://github.com/php/php-src/pulls> Previous Comments: ------------------------------------------------------------------------ [2018-08-19 18:03:28] php at nearlyfreespeech dot net This issue is still present on PHP 7.2 with FreeBSD 11.2. The code for php_get_gid_by_name() needs the same fix as well, otherwise chgrp() gets the same result. diff --git a/ext/standard/filestat.c b/ext/standard/filestat.c index e730b5ae8d..deb0600d9f 100644 --- a/ext/standard/filestat.c +++ b/ext/standard/filestat.c @@ -303,6 +303,8 @@ PHPAPI int php_get_gid_by_name(const char *name, gid_t *gid) long grbuflen = sysconf(_SC_GETGR_R_SIZE_MAX); char *grbuf; + if ( -1 == grbuflen ) + grbuflen = 1024; if (grbuflen < 1) { return FAILURE; } @@ -439,6 +441,8 @@ PHPAPI uid_t php_get_uid_by_name(const char *name, uid_t *uid) long pwbuflen = sysconf(_SC_GETPW_R_SIZE_MAX); char *pwbuf; + if ( -1 == pwbuflen ) + pwbuflen = 1024; if (pwbuflen < 1) { return FAILURE; } ------------------------------------------------------------------------ [2015-01-20 13:06:51] lg at efficientip dot com Description: ------------ chown() does not work when PHP is compiling with ZTS on FreeBSD, In fact sysconf(_SC_GETGR_R_SIZE_MAX) may return -1 if there is no hard limit on the size of the buffer needed to store all the groups returned. Test script: --------------- <?php exec('touch /tmp/test') chown('/tmp/test', 'www'); ?> Expected result: ---------------- root:/tmp # php test.php root:/tmp # ls -l /tmp/test -rw-r--r-- 1 www wheel 0 Jan 20 13:19 /tmp/test Actual result: -------------- root:/tmp # php test.php Warning: chown(): Unable to find uid for www in /tmp/test.php on line 4 root:/tmp # ls -l /tmp/test -rw-r--r-- 1 root wheel 0 Jan 20 13:19 /tmp/test ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=68861&edit=1