Bug #81424 [Csd->ReO]: PCRE2 10.35 JIT performance regression

From:	cmb@php.net	Date:	Tue, 05 Oct 2021 09:55:38 +0000
Subject:	Bug #81424 [Csd->ReO]: PCRE2 10.35 JIT performance regression
References:	1	Groups:	php.bugs
Request:	Send a blank email to php-bugs+get-237036@lists.php.net to get a copy of this message

Edit report at https://bugs.php.net/bug.php?id=81424&edit=1

 ID:                 81424
 Updated by:         cmb@php.net
 Reported by:        nospam at briat dot org
 Summary:            PCRE2 10.35 JIT performance regression
-Status:             Closed
+Status:             Re-Opened
 Type:               Bug
 Package:            PCRE related
 Operating System:   *
 PHP Version:        7.4
 Assigned To:        cmb
 Block user comment: N
 Private report:     N

 New Comment:

Since this fix introduces a functional regression[1], it has been
reverted for now.

[1] <https://github.com/PhilipHazel/pcre2/issues/21>


Previous Comments:
------------------------------------------------------------------------
[2021-09-13 12:40:45] git@php.net

Automatic comment on behalf of cmb69
Revision: https://github.com/php/php-src/commit/a2471383fec332ae30827c7e3f4f9451420f1f0b
Log: Fix #81424: PCRE2 10.35 JIT performance regression

------------------------------------------------------------------------
[2021-09-10 10:47:17] cmb@php.net

The following pull request has been associated:

Patch Name: Fix #81424: PCRE2 10.35 JIT performance regression
On GitHub:  https://github.com/php/php-src/pull/7484
Patch:      https://github.com/php/php-src/pull/7484.patch

------------------------------------------------------------------------
[2021-09-08 15:02:00] cmb@php.net

> […] I think that your regex is maybe equivalent for matching but
> not for replacing […]

Oh, right.  Maybe some other improvement can be made for that.
Anyway, let's wait on the upstream decision. :)

------------------------------------------------------------------------
[2021-09-08 14:41:14] nospam at briat dot org

Here the issue https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/issues/63

For the record, I think that your regex is maybe equivalent for matching but not for replacing: $css
= preg_replace('/[^{};\/\n]+\{\}/S', '', $css); => match and replace the
whole css declaration.

------------------------------------------------------------------------
[2021-09-08 13:47:02] nospam at briat dot org

Thanks for the analysis.
I will also fill an issue on https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=81424


--
Edit this bug report at https://bugs.php.net/bug.php?id=81424&edit=1


   

Thread (21 messages)

• nospam at briat dot orgTue, 07 Sep 2021 17:11:14 +0000
  • dharman@php.netTue, 07 Sep 2021 20:37:17 +0000Bug #81424 [Opn->Fbk]: Since PCRE 10.35, pc
  • nospam at briat dot orgTue, 07 Sep 2021 21:02:28 +0000Bug #81424 [Fbk->Opn]: Since PCRE 10.35, pc
  • nikic@php.netWed, 08 Sep 2021 08:50:09 +0000Bug #81424 [Opn]: Since PCRE 10.35, pc
  • nospam at briat dot orgWed, 08 Sep 2021 10:05:34 +0000Bug #81424 [Opn]: Since PCRE 10.35, pc
  • cmb@php.netWed, 08 Sep 2021 10:07:59 +0000Bug #81424 [Opn->Fbk]: Since PCRE 10.35, pc
  • cmb@php.netWed, 08 Sep 2021 10:08:11 +0000Bug #81424 [Fbk->Opn]: Since PCRE 10.35, pc
  • cmb@php.netWed, 08 Sep 2021 11:09:59 +0000Bug #81424 [Asn->Ver]: PCRE2 10.35 JIT performance regression
  • cmb@php.netWed, 08 Sep 2021 12:16:29 +0000Bug #81424 [Ver]: PCRE2 10.35 JIT performance regression
  • cmb@php.netWed, 08 Sep 2021 12:34:28 +0000Bug #81424 [Ver]: PCRE2 10.35 JIT performance regression
  • nospam at briat dot orgWed, 08 Sep 2021 13:47:02 +0000Bug #81424 [Ver]: PCRE2 10.35 JIT performance regression
  • nospam at briat dot orgWed, 08 Sep 2021 14:41:14 +0000Bug #81424 [Ver]: PCRE2 10.35 JIT performance regression
  • cmb@php.netWed, 08 Sep 2021 15:02:00 +0000Bug #81424 [Ver]: PCRE2 10.35 JIT performance regression
  • cmb@php.netFri, 10 Sep 2021 10:47:17 +0000Bug #81424 [PATCH]: PCRE2 10.35 JIT performance regression
  • git@php.netMon, 13 Sep 2021 12:40:45 +0000Bug #81424 [Ver->Csd]: PCRE2 10.35 JIT performance regression
  • cmb@php.netTue, 05 Oct 2021 09:55:38 +0000Bug #81424 [Csd->ReO]: PCRE2 10.35 JIT performance regression
  • cmb@php.netTue, 12 Oct 2021 10:07:31 +0000Bug #81424 [PATCH]: PCRE2 10.35 JIT performance regression
  • git@php.netTue, 12 Oct 2021 12:23:53 +0000Bug #81424 [ReO->Csd]: PCRE2 10.35 JIT performance regression
  • hegyre at gmail dot comMon, 25 Oct 2021 16:09:59 +0000Bug #81424 [Com]: PCRE2 10.35 JIT performance regression
  • cmb@php.netMon, 25 Oct 2021 16:35:14 +0000Bug #81424 [Csd]: PCRE2 10.35 JIT performance regression
  • apostnikov at gmail dot comWed, 27 Oct 2021 23:33:37 +0000Bug #81424 [Com]: PCRE2 10.35 JIT performance regression