Bug #81424 [PATCH]: PCRE2 10.35 JIT performance regression

From: Date: Tue, 12 Oct 2021 10:07:31 +0000
Subject: Bug #81424 [PATCH]: PCRE2 10.35 JIT performance regression
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-237155@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=81424&edit=1

 ID:                 81424
 Patch added by:     cmb@php.net
 Reported by:        nospam at briat dot org
 Summary:            PCRE2 10.35 JIT performance regression
 Status:             Re-Opened
 Type:               Bug
 Package:            PCRE related
 Operating System:   *
 PHP Version:        7.4
 Assigned To:        cmb
 Block user comment: N
 Private report:     N

 New Comment:

The following pull request has been associated:

Patch Name: Fix #81424: PCRE2 10.35 JIT performance regression
On GitHub:  https://github.com/php/php-src/pull/7573
Patch:      https://github.com/php/php-src/pull/7573.patch


Previous Comments:
------------------------------------------------------------------------
[2021-10-05 09:55:38] cmb@php.net

Since this fix introduces a functional regression[1], it has been
reverted for now.

[1] <https://github.com/PhilipHazel/pcre2/issues/21>

------------------------------------------------------------------------
[2021-09-13 12:40:45] git@php.net

Automatic comment on behalf of cmb69
Revision: https://github.com/php/php-src/commit/a2471383fec332ae30827c7e3f4f9451420f1f0b
Log: Fix #81424: PCRE2 10.35 JIT performance regression

------------------------------------------------------------------------
[2021-09-10 10:47:17] cmb@php.net

The following pull request has been associated:

Patch Name: Fix #81424: PCRE2 10.35 JIT performance regression
On GitHub:  https://github.com/php/php-src/pull/7484
Patch:      https://github.com/php/php-src/pull/7484.patch

------------------------------------------------------------------------
[2021-09-08 15:02:00] cmb@php.net

> […] I think that your regex is maybe equivalent for matching but
> not for replacing […]

Oh, right.  Maybe some other improvement can be made for that.
Anyway, let's wait on the upstream decision. :)

------------------------------------------------------------------------
[2021-09-08 14:41:14] nospam at briat dot org

Here the issue https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/issues/63

For the record, I think that your regex is maybe equivalent for matching but not for replacing: $css
= preg_replace('/[^{};\/\n]+\{\}/S', '', $css); => match and replace the
whole css declaration.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=81424


--
Edit this bug report at https://bugs.php.net/bug.php?id=81424&edit=1


Thread (21 messages)

« previous php.bugs (#237155) next »