Re: com php-src: Give a reason why the test was skipped:ext/intl/tests/dateformat_set_timezone_id2.phpt ext/intl/tests/formatter_format2.phpt
ext/intl/tests/formatter format currency2.phpt ext/in
| From: | Gabriel Caruso | Date: | Thu, 02 Aug 2018 10:52:41 +0000 |
| Subject: | Re: com php-src: Give a reason why the test was skipped:ext/intl/tests/dateformat_set_timezone_id2.phpt ext/intl/tests/formatter_format2.phpt ext/intl/tests/formatter format currency2.phpt ext/in |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-102779@lists.php.net to get a copy of this message | ||
Hi Christoph
Hi Gabriel!
>
> On 02.08.2018 at 03:18, Gabriel Caruso wrote:
>
> > Commit: dc4e47710bbdab061f82d2e1c67a9de53566fc11
> > Author: Gabriel Caruso <carusogabriel34@gmail.com> Wed, 1
> Aug 2018 22:18:57 -0300
> > Parents: 6f9ebe677bf31d0c64046f18e6b0ac75340cb93e
> > Branches: master
> >
> > Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=dc4e47710bbdab061f82d2e1c67a9de53566fc11
> >
> > Log:
> > Give a reason why the test was skipped
>
> There seem to be several off-by-one errors regarding the supported
> version. For instance, if the skip condition is
>
version_compare(INTL_ICU_VERSION, '4.8') < 0, the
> test is supposed to
> run under ICU >= 4.8, not only on ICU > 4.8.
>
> --
> Christoph M. Becker
>
So we should fix to version_compare(INTL_ICU_VERSION, '4.8') < 0, right?
I've noticed that we can run some of these tests in version in the latest
INTL versions, I'll create a PR soon.
I'm working on a patch for run more tests on Windows for now, but thank you
for noticed that.
Regards,
--
Gabriel Caruso