Re: com php-src: Give a reason why the test was skipped:ext/intl/tests/dateformat_set_timezone_id2.phptext/intl/tests/formatter_format2.phpt
ext/intl/tests/formatter format currency2.phpt ext/in
| From: | Christoph M. Becker | Date: | Thu, 02 Aug 2018 11:09:33 +0000 |
| Subject: | Re: com php-src: Give a reason why the test was skipped:ext/intl/tests/dateformat_set_timezone_id2.phptext/intl/tests/formatter_format2.phpt ext/intl/tests/formatter format currency2.phpt ext/in |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-102781@lists.php.net to get a copy of this message | ||
On 02.08.2018 at 12:52, Gabriel Caruso wrote:
>> On 02.08.2018 at 03:18, Gabriel Caruso wrote:
>>
>>> Commit: dc4e47710bbdab061f82d2e1c67a9de53566fc11
>>> Author: Gabriel Caruso <carusogabriel34@gmail.com> Wed, 1
>> Aug 2018 22:18:57 -0300
>>> Parents: 6f9ebe677bf31d0c64046f18e6b0ac75340cb93e
>>> Branches: master
>>>
>>> Link:
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=dc4e47710bbdab061f82d2e1c67a9de53566fc11
>>>
>>> Log:
>>> Give a reason why the test was skipped
>>
>> There seem to be several off-by-one errors regarding the supported
>> version. For instance, if the skip condition is
>>
version_compare(INTL_ICU_VERSION, '4.8') < 0,
>> the test is supposed to
>> run under ICU >= 4.8, not only on ICU > 4.8.
>
> So we should fix to version_compare(INTL_ICU_VERSION, '4.8') <
> 0, right?
I would rather change the printed skip reason (i.e. 'skip for ICU >=
4.8'), unless the test would actually fail for ICU 4.8.
--
Christoph M. Becker