Re: com php-src: Fix tests in some builds:ext/standard/tests/mail/bug69115.phpt

From: Date: Fri, 31 Aug 2018 11:38:04 +0000
Subject: Re: com php-src: Fix tests in some builds:ext/standard/tests/mail/bug69115.phpt
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-102949@lists.php.net to get a copy of this message
Hi Gabriel! On 31.08.2018 at 13:09, Gabriel Caruso wrote: > Commit: 4fcaebbab82ea5fb66393bdbb5a4d0d57678aaee > Author: Gabriel Caruso <carusogabriel34@gmail.com> Fri, 31 Aug 2018 08:09:14 > -0300 > Parents: ecb698b21dc27de088cc2e03436d5ff5e7e48391 > Branches: master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=4fcaebbab82ea5fb66393bdbb5a4d0d57678aaee > > Log: > Fix tests in some builds > > Looks like the EXPECTREGEX was eating the =DONE= section > > Changed paths: > M ext/standard/tests/mail/bug69115.phpt > > > Diff: > diff --git a/ext/standard/tests/mail/bug69115.phpt b/ext/standard/tests/mail/bug69115.phpt > index d907a3f..8a4bed1 100644 > --- a/ext/standard/tests/mail/bug69115.phpt > +++ b/ext/standard/tests/mail/bug69115.phpt > @@ -12,4 +12,3 @@ mail('user@example.com', 'My Subject', $message, > "From: me@me.me"); > ===DONE=== > --EXPECTREGEX-- > .* > -===DONE=== This doesn't look right. The test is supposed to check that the mail() call doesn't crash[1], but removing the ===DONE=== wouldn't verify this anymore. Since the test doesn't need to check any warnings/notices, we may as well silence the mail() call (i.e. apply the @ operator). [1] <http://git.php.net/?p=php-src.git;a=blob;f=ext/standard/tests/mail/bug69115.phpt;h=8a4bed1296917ea79cf14388e32e2080f88baf5d;hb=4fcaebbab82ea5fb66393bdbb5a4d0d57678aaee> -- Christoph M. Becker

« previous php.cvs (#102949) next »