Re: com php-src: Fix tests in some builds:ext/standard/tests/mail/bug69115.phpt

From: Date: Fri, 31 Aug 2018 12:01:38 +0000
Subject: Re: com php-src: Fix tests in some builds:ext/standard/tests/mail/bug69115.phpt
References: 1 2  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-102951@lists.php.net to get a copy of this message
Hi Christoph, This doesn't look right. The test is supposed to check that the mail() > call doesn't crash[1], but removing the ===DONE=== wouldn't verify this > anymore. Since the test doesn't need to check any warnings/notices, we > may as well silence the mail() call (i.e. apply the @ operator). > > [1] > < > > http://git.php.net/?p=php-src.git;a=blob;f=ext/standard/tests/mail/bug69115.phpt;h=8a4bed1296917ea79cf14388e32e2080f88baf5d;hb=4fcaebbab82ea5fb66393bdbb5a4d0d57678aaee > > > > -- > Christoph M. Becker > Actually, I've made another change reverting some previously changes ( http://git.php.net/?p=php-src.git;a=commit;h=6dd9fad0). Looks like this test isn't supposed to run on Unix system at all. Thanks, -- Gabriel Caruso

« previous php.cvs (#102951) next »