Re: cvs: php4 /ext/exif exif.c /ext/ftp php_ftp.c /ext/gd gd.c /ext/mailparse mailparse.c /ext/ming ming.c /ext/pgsql pgsql.c /ext/standard
basic_functions.c ftp_fopen_wrapper.c http_fopen_wrapper.c image.c php_fopen_wrapper.c php_fopen_wrappers.h /ext/zlib php_zlib.h zlib.c
zlib_fopen_wrapper.c /main main.c network.c php_network.h php_streams.h streams.c
| From: | Andi Gutmans | Date: | Mon, 18 Mar 2002 05:16:53 +0000 |
| Subject: | Re: cvs: php4 /ext/exif exif.c /ext/ftp php_ftp.c /ext/gd gd.c /ext/mailparse mailparse.c /ext/ming ming.c /ext/pgsql pgsql.c /ext/standard basic_functions.c ftp_fopen_wrapper.c http_fopen_wrapper.c image.c php_fopen_wrapper.c php_fopen_wrappers.h /ext/zlib php_zlib.h zlib.c zlib_fopen_wrapper.c /main main.c network.c php_network.h php_streams.h streams.c |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-10325@lists.php.net to get a copy of this message | ||
This patch is really not a good idea. It's always better to not create #define's for your functions. Why not keep it the way it is? Also, you should pass TSRMLS_CC and not STREAMS_CC because this is the standard in all of PHP and the correct way to do it (even if it works the way you did it). People looking at the code will get confused.
Andi
At 22:50 17/03/2002 +0000, Wez Furlong wrote:
wez Sun Mar 17 17:50:59 2002 EDTModified files:/php4/ext/exif exif.c /php4/ext/ftp php_ftp.c /php4/ext/gd gd.c /php4/ext/mailparse mailparse.c /php4/ext/ming ming.c /php4/ext/pgsql pgsql.c /php4/ext/standard basic_functions.c ftp_fopen_wrapper.c http_fopen_wrapper.c image.c php_fopen_wrapper.c php_fopen_wrappers.h /php4/ext/zlib php_zlib.h zlib.c zlib_fopen_wrapper.c /php4/main main.c network.c php_network.h php_streams.h streams.cLog: Streams now make more use of the memory manager, so tracking down leaking streams should be easier. # I hate these big commits -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php