Re: Re: php4 /ext/standard php_smart_str.h
| From: | Rasmus Lerdorf | Date: | Tue, 23 Apr 2002 18:57:46 +0000 |
| Subject: | Re: Re: php4 /ext/standard php_smart_str.h | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-11358@lists.php.net to get a copy of this message | ||
Harald, casting simply to shut up a bogus compiler warnings can lead to
many more problems than it solves. The goal here is correct code, not
code simply there to trick compilers into not spewing bogus warnings.
-Ramus
On Tue, 23 Apr 2002, Harald Radi wrote:
> > sas Mon Apr 22 16:42:01 2002 EDT
> >
> > Modified files:
> > /php4/ext/standard php_smart_str.h
> > Log:
> > remove unnecessary casts
> > # if you mind the bogus warnings, you can either switch the compiler
> > # or decrease the warning level
>
> what's wrong with you guy ? if everybody starts coding like this we'd
> soon have a php build with 500+ warnings. if you mind a cast that
> produces a less dodgy compiler output on many systems then you can still
> stick it up somewhere were you can hardly find light.
>
> -harald.
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>