Re: Re: php4 /ext/standard php_smart_str.h

At 21:55 23/04/2002 +0200, Sascha Schumann wrote:

what's wrong with you guy ? if everybody starts coding like this we'd soon have a php build with 500+ warnings. if you mind a cast that produces a less dodgy compiler output on many systems then you can still stick it up somewhere were you can hardly find light.

    You might be unaware of a private discussion which took place
    before your commit.  Sebastian alerted me about the warning
    and we agreed on decreasing the warning level for the
    source-file, because the code in question is correct and the
    warning is bogus.  I probably should have noted that in my
    commit message as well.  I didn't know that it would mean so
    much to anyone :-)

I don't like compiler directives which decrease the warning level because I might miss out on other warnings. I think it's the worst solution. I prefer the warnings to stay in there if they aren't resolved. Sebastian will have to learn to live with them :) Andi