Re: cvs: php4 /ext/domxml php_domxml.c php_domxml.h
| From: | Christian Stocker | Date: | Fri, 31 May 2002 06:26:14 +0000 |
| Subject: | Re: cvs: php4 /ext/domxml php_domxml.c php_domxml.h | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-12176@lists.php.net to get a copy of this message | ||
Uh Big Patch :)
It looks ok to me (which doesn't say anything :) )
But one comment just for the record:
It would be very benefical, if one would not mix different stuff in one
commit (i'm not any better in that). I had a hard time finding the memory
leak last time and it will make debugging much easier in the future ...
chregu
On Fri, 31 May 2002, Brad LaFountain wrote:
> rodif_bl Fri May 31 01:58:40 2002 EDT
>
> Modified files:
> /php4/ext/domxml php_domxml.c php_domxml.h
> Log:
> added the ability to use new keywork with domxmls objects "new DomDocument()"
> instead of xmldoc. This also allows you to create nodes without having
> a whole document "new DomElement("foo")".
>
> moved DOMXML_API_VERSION to php_domxml.h
> exposed php_domobject_new for other extensions to use
> removed some un-needed code
>
>
--
nam...christian stocker adr...bremgartnerstr. 66, ch-8003 zurich
pho...+41 1 451 6021 www...http://phant.ch/chregu
mob...+41 76 561 8860 ema...chregu@phant.ch
wor...+41 1 240 5670 gpg...0x5CE1DECB