Re: cvs: php4 /ext/gd gd.c

On Wed, 26 Jun 2002, Marcus Börger wrote: >The first part of the patch maps imageellipse to imagearc >This is the more general way since we could have also mapped it to >imagefilledarc with style gdNoFill (So Rasmus was correct on this). > >Since compiling it more than once i also fixed warnings with the >calls to getmbi and skipheader. Both require additional header >file wbmp.h that can be assumed being present if HAVE_GD_WBMP >is defined. Additionally there is an inconsistency in gd files that You know that saying about 'assume' ? :) wbmp.h is not installed with gd-1.8.4 or gd-2.0.1. Not if you don't copy it manually. --Jani >requires typeconversion for the function pointer parameter of both >getmbi and skipheader. >marcus > >At 00:39 26.06.2002, Jani Taskinen wrote: >>On Tue, 25 Jun 2002, Marcus Börger wrote: >> >> >+/* $Id: gd.c,v 1.192 2002/06/25 22:23:41 helly Exp $ */ >> > >> > /* gd 1.2 is copyright 1994, 1995, Quest Protein Database Center, >> > Cold Spring Harbor Labs. */ >> >@@ -60,6 +60,9 @@ >> > #include <gdfontmb.h> /* 3 Medium bold font */ >> > #include <gdfontl.h> /* 4 Large font */ >> > #include <gdfontg.h> /* 5 Giant font */ >> >+#ifdef HAVE_GD_WBMP >> >+#include <wbmp.h> >> >+#endif >> >> What's this?! Please check your commits with 'cvs diff' before >> actually committing.. >> >> > gdIOCtx *io_ctx; >> > io_ctx = gdNewDynamicCtx (8, data); >> > if (io_ctx) { >> >- if (getmbi(gdGetC, io_ctx) == 0 && >> skipheader(gdGetC, io_ctx) == 0 ) { >> >+ if (getmbi((int(*)(void*))gdGetC, io_ctx) == 0 && >> skipheader((int(*)(void*))gdGetC, io_ctx) == 0 ) { >> >> Was this somehow related to this commit? >> >> --Jani >> >> >>-- >>PHP CVS Mailing List (http://www.php.net/) >>To unsubscribe, visit: http://www.php.net/unsub.php > --