Re: cvs: php4 /ext/gd gd.c

> > >I don't really like the idea of using the bundled wbmp.h to make a > > >system-installed libgd work. Chances are our wbmp.h will not match the > > >system's libgd.a. Currently there are 2 prototype differences between the > > >1.8.3 wbmp.h and the 2.0.1 wbmp.h. But they may diverge further and there > > >might be older code out there than 1.8.3. If wbmp.h is not installed and > > >someone is building against the system libgd, then we play it safe and we > > >don't support wbmp. > > > > Are you all on crack or what? :) > > The reason to even include that file in the first place > > was to kill some compile _warnings_ !! > > > > It has worked just fine for how many years now? > > Why it suddenly wouldn't work? Just revert those > > changes that actually needed this file. > > > > Btw. wbmp support came in 1.8.0 ? And those proto changes > > there are don't matter since we only use getmbi() ? > > IMO, it's just fine as it is now.. > > > > --Jani > > Said well, i simply wanted to fix the warnings.... But we will run into a problem with this if the 2.x wbmp.h that we bundle diverges to the point that it is completely incompatible with libgd-1.8.0. That was my point. And no, I am not on crack. -Rasmus