Re: cvs: php4 /ext/odbc php_odbc.c

At 02:45 13.08.2002, Dan Kalowsky wrote:

kalowsky                Mon Aug 12 20:45:09 2002 EDT

Modified files:

    /php4/ext/odbc      php_odbc.c

Log: Let to php_error_docref revolution begin -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

if docref is only the function name you do not need to set it. somply set it to NULL php_error_docref() does the rest for you. However the following wasn't intended (old style error and loosing return), was it? @@ -1135,8 +1135,7 @@

        }

        if (zend_get_parameters_ex(2, &zv_conn, &zv_fetch_type) == FAILURE) {
-               php_error(E_WARNING, "Unable to get parameters");
-               RETURN_FALSE;
+               php_error(E_WARNING, "%s(): Unable to get parameters", get_active_function_name(TSRMLS_C));
        }

marcus