Re: cvs: php4 /ext/odbc php_odbc.c

On Tue, 13 Aug 2002, Marcus [iso-8859-1] Börger wrote: > if docref is only the function name you do not need to set it. > somply set it to NULL php_error_docref() does the rest for you. > > However the following wasn't intended (old style error and loosing return), > was it? > @@ -1135,8 +1135,7 @@ > } > > if (zend_get_parameters_ex(2, &zv_conn, &zv_fetch_type) == FAILURE) { > - php_error(E_WARNING, "Unable to get parameters"); > - RETURN_FALSE; > + php_error(E_WARNING, "%s(): Unable to get parameters", > get_active_function_name(TSRMLS_C)); Umm no. I'll fix that. >---------------------------------------------------------------< Dan Kalowsky "A little less conversation, http://www.deadmime.org/~dank a little more action." dank-nom@aps-deadmime.org - "A Little Less Conversation", kalowsky@php.net Elvis Presley