Re: cvs: php4 /ext/zlib zlib.c

At 11:38 22.08.2002, Stefan Roehrich wrote:

sr              Thu Aug 22 05:38:55 2002 EDT

Modified files:

    /php4/ext/zlib      zlib.c

Log: Fixed prototype. Fixed double printing of function name in docref error messages. Index: php4/ext/zlib/zlib.c diff -u php4/ext/zlib/zlib.c:1.145 php4/ext/zlib/zlib.c:1.146 --- php4/ext/zlib/zlib.c:1.145 Tue Aug 20 16:22:30 2002

+++ php4/ext/zlib/zlib.c        Thu Aug 22 05:38:55 2002

@@ -18,7 +18,7 @@

    |          Jade Nicoletti <nicoletti@nns.ch>                           |
    +----------------------------------------------------------------------+

*/ -/* $Id: zlib.c,v 1.145 2002/08/20 20:22:30 helly Exp $ */ +/* $Id: zlib.c,v 1.146 2002/08/22 09:38:55 sr Exp $ */ #define IS_EXT_MODULE #ifdef HAVE_CONFIG_H @@ -295,7 +295,8 @@

        /* using a stream here is a bit more efficient (resource wise) than php_gzopen_wrapper */
        stream = php_stream_gzopen(NULL, Z_STRVAL_PP(filename), "rb", use_include_path|ENFORCE_SAFE_MODE|REPORT_ERRORS, NULL, NULL STREAMS_CC TSRMLS_CC);
        if (stream == NULL) {
-               php_error_docref(NULL TSRMLS_CC, E_WARNING, "gzFile(\"%s\") - %s", Z_STRVAL_PP(filename), strerror(errno));
+               /* Error reporting is already done by stream code
+                 php_error_docref(NULL TSRMLS_CC, E_WARNING, "gzFile(\"%s\") - %s", Z_STRVAL_PP(filename), strerror(errno)); */

But why did you remove the above warning? (snip rest)