Re: cvs: php4 /ext/zlib zlib.c

On 2002-08-22 12:02:17, Marcus Börger wrote: > > /* using a stream here is a bit more efficient (resource wise) > >than php_gzopen_wrapper */ > > stream = php_stream_gzopen(NULL, Z_STRVAL_PP(filename), "rb", > >use_include_path|ENFORCE_SAFE_MODE|REPORT_ERRORS, NULL, NULL STREAMS_CC > >TSRMLS_CC); > > if (stream == NULL) { > >- php_error_docref(NULL TSRMLS_CC, E_WARNING, > >"gzFile(\"%s\") - %s", Z_STRVAL_PP(filename), strerror(errno)); > >+ /* Error reporting is already done by stream code > >+ php_error_docref(NULL TSRMLS_CC, E_WARNING, > >"gzFile(\"%s\") - %s", Z_STRVAL_PP(filename), strerror(errno)); */ > > But why did you remove the above warning? On my tests I already got an error from the stream code, so with this additional warning I got the error message twice. In order to avoid this, I removed the warning, now I get only one error message, if I'm e.g. trying to gzfile() a non-existant file. Stefan -- Stefan Röhrich stefan@roehri.ch, sr@linux.de http://www.roehri.ch/~sr/