Re: cvs: php4 /ext/standard basic_functions.c var.c /main

Zeev Suraski wrote:

At 17:00 03/10/2002, Yasuo Ohgaki wrote:

Zeev Suraski wrote:

Yasuo, Can you explain how come the output buffering code pays any attention to implicit_flush, when I repeatedly said that output buffering and implicit_flush are COMPLETELY unrelated?

This patch has nothing to do with implicit_flush ini directive.

-       if (OG(active_ob_buffer).chunk_size
-                       && OG(active_ob_buffer).text_length >= OG(active_ob_buffer).chunk_size) {
+       /* If implicit_flush is On, send contents to next buffer and return. */
+       if (OG(implicit_flush) || OG(active_ob_buffer).chunk_size
+               && OG(active_ob_buffer).text_length >= OG(active_ob_buffer).chunk_size)
+       {
                zval *output_handler = OG(active_ob_buffer).output_handler;

How does it have nothing to do with the implicit_flush INI directive, if turning this directive on calls php_start_implicit_flush(), which in turn sets OG(implicit_flush), and in turn used in that if??

OG(implicit_flush) != PG(implicit_flush)

Why is it necessary to explicitly disable output in all of the places where you added set_status() calls??

To prevent implicit_flushing. As Derick noticed. <?php var_exprot('var'); ?> prints out exported var w/o it. -- Yasuo Ohgaki