Re: cvs: php4 /ext/gd/tests bug19266.phpt
| From: | Rasmus Lerdorf | Date: | Fri, 11 Oct 2002 13:59:45 +0000 |
| Subject: | Re: cvs: php4 /ext/gd/tests bug19266.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-14834@lists.php.net to get a copy of this message | ||
On Fri, 11 Oct 2002, Andi Gutmans wrote:
> At 02:52 PM 10/11/2002 +0200, Derick Rethans wrote:
> >On Fri, 11 Oct 2002, Andi Gutmans wrote:
> >
> > > We really shouldn't change PHP just so that tests end up being better ;)
> >
> >We're trying to the point that there may be no failed tests when we
> >release, and this is needed to make this test pass. The non-bundled GD
> >crashes when this test is run.
>
> You shouldn't clutter PHP just so that the make test prints out a nice
> "passed". If the non-bundled GD crashes there's no reason the test
> shouldn't crash IMO.
I agree. The test harness is not just for our own QA. It is also a
series of tests for people to run on their systems to see what works and
what doesn't. If they are using the non-bundled GD then this function
is broken and we shouldn't hide this fact from them.
-Rasmus