Re: cvs: php4 /ext/gd/tests bug19266.phpt

At 02:52 PM 10/11/2002 +0200, Derick Rethans wrote:

On Fri, 11 Oct 2002, Andi Gutmans wrote: We really shouldn't change PHP just so that tests end up being better ;) We're trying to the point that there may be no failed tests when we release, and this is needed to make this test pass. The non-bundled GD crashes when this test is run.

You shouldn't clutter PHP just so that the make test prints out a nice "passed". If the non-bundled GD crashes there's no reason the test shouldn't crash IMO. Andi

Derick At 10:08 AM 10/11/2002 +0000, Derick Rethans wrote:

derick          Fri Oct 11 06:08:42 2002 EDT

Modified files:

    /php4/ext/gd/tests  bug19266.phpt

Log: - Skip if an external lib gd is used (which always has this crash-bug) Index: php4/ext/gd/tests/bug19266.phpt diff -u php4/ext/gd/tests/bug19266.phpt:1.2 php4/ext/gd/tests/bug19266.phpt:1.3 --- php4/ext/gd/tests/bug19266.phpt:1.2 Wed Oct 9 09:54:21 2002

+++ php4/ext/gd/tests/bug19266.phpt     Fri Oct 11 06:08:42 2002

@@ -1,7 +1,7 @@ --TEST-- gdimagefill() function (Bug #19366 (in bundled libgd)) --SKIPIF-- -<?php if (!extension_loaded('gd')) die("skip\n"); ?> +<?php if (!extension_loaded('gd') || !HAVE_BUNDLED_GD) die("skip\n"); ?> --POST-- --GET-- --INI-- -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

-- ---------------------------------------------------------------------------

 Derick Rethans                                   http://derickrethans.nl/

JDI Media Solutions --------------[ if you hold a unix shell to your ear, do you hear the c? ]-