Re: cvs: php4 /ext/gd gd.c

At 02:50 PM 10/11/2002 +0200, Derick Rethans wrote:

On Fri, 11 Oct 2002, Andi Gutmans wrote: I don't think this is a good idea. I'd definitely change the name to GD_something but it still doesn't make so much sense to me. When would people use this and not function_exists()? Because some functions behave different in the bundled and non-bundled versions of GD. This will only become more of a problem as we're fixing more in the bundled library.

In that case we should maybe consider to only allow the bundled one. Anyway, although I am -1 for this constant if it is decided to keep it it should be GD_*. Andi

Derick At 09:49 AM 10/11/2002 +0000, Derick Rethans wrote:

derick          Fri Oct 11 05:49:38 2002 EDT

Modified files:

    /php4/ext/gd        gd.c

Log: - Add indetified for bundled GD Index: php4/ext/gd/gd.c diff -u php4/ext/gd/gd.c:1.214 php4/ext/gd/gd.c:1.215

--- php4/ext/gd/gd.c:1.214      Thu Sep 19 21:25:55 2002
+++ php4/ext/gd/gd.c    Fri Oct 11 05:49:38 2002

@@ -18,7 +18,7 @@

+----------------------------------------------------------------------+

*/ -/* $Id: gd.c,v 1.214 2002/09/20 01:25:55 iliaa Exp $ */ +/* $Id: gd.c,v 1.215 2002/10/11 09:49:38 derick Exp $ */ /* gd 1.2 is copyright 1994, 1995, Quest Protein Database Center,

    Cold Spring Harbor Labs. */

@@ -346,6 +346,9 @@

        REGISTER_LONG_CONSTANT("IMG_EFFECT_ALPHABLEND",

gdEffectAlphaBlend, CONST_CS | CONST_PERSISTENT);

        REGISTER_LONG_CONSTANT("IMG_EFFECT_NORMAL", gdEffectNormal,

CONST_CS | CONST_PERSISTENT);

        REGISTER_LONG_CONSTANT("IMG_EFFECT_OVERLAY", gdEffectOverlay,

CONST_CS | CONST_PERSISTENT);

+       REGISTER_LONG_CONSTANT("HAVE_BUNDLED_GD", 1, CONST_CS |

CONST_PERSISTENT); +#else

+       REGISTER_LONG_CONSTANT("HAVE_BUNDLED_GD", 0, CONST_CS |

CONST_PERSISTENT); #endif

        return SUCCESS;

} -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

-- ---------------------------------------------------------------------------

 Derick Rethans                                   http://derickrethans.nl/

JDI Media Solutions --------------[ if you hold a unix shell to your ear, do you hear the c? ]-