Re: Re: cvs: php4 / Makefile.global

Ilia A. wrote:

On October 22, 2002 10:30 pm, Yasuo Ohgaki wrote:

Ilia A. wrote:

What's the point of _not_ specifying certain ini for run-tests.php? In other words, what is advantages?

Because those ini settings may be the ones causing the problems. Unusual ini settings could lead to discovery of various problems, which may not show up under 'normal' configuration. We are trying to determine if the compiled PHP is working properly with the user's settings and system configuration, not just with predefined settings.

No augment for that. ini used by run-tests.php has nothing to do with the ini used by phpt. It seems there is confusion about this.

That is completely true. However, while the test scripts are mostly very basic 'theoretical' tests of various functions, run-tests.php is a fairly complex script with a practical application. IMHO, this script itself is part of the test. Should it fail for whatever reason, that would indicate some 'break' due to ini settings, allowing the user as well as the developers (should a user submit a bug report) to determine if there is a problem and handle it accordingly.

I agree. We need real complex tests. However, I have different opinion. We do need complex tests, but we don't want to people tells us "Hey it does not work" merely slight ini setting difference _for_ run-tests.php. (Again, phpt is different. We _should_ test with various ini settings as it does now) The fact tells us that even we don't understand which setting is affecting what. Therefore, I think we are better to specify ini. It's a lot easier for us. e.g. Do we want to make run-tests.php run well under magic_quote_runtime , magic_quote, etc enabled environments? Real test should be done with real applications, IMO. In my case, I test against my web applications see if it works as used to be. -- Yasuo Ohgaki