Re: Re: cvs: php4 / Makefile.global

Ilia A. wrote:

On October 22, 2002 11:04 pm, Yasuo Ohgaki wrote:

Ilia A. wrote:

On October 22, 2002 10:30 pm, Yasuo Ohgaki wrote:

Ilia A. wrote:

What's the point of _not_ specifying certain ini for run-tests.php? In other words, what is advantages?

Because those ini settings may be the ones causing the problems. Unusual ini settings could lead to discovery of various problems, which may not show up under 'normal' configuration. We are trying to determine if the compiled PHP is working properly with the user's settings and system configuration, not just with predefined settings.

No augment for that. ini used by run-tests.php has nothing to do with the ini used by phpt. It seems there is confusion about this.

That is completely true. However, while the test scripts are mostly very basic 'theoretical' tests of various functions, run-tests.php is a fairly complex script with a practical application. IMHO, this script itself is part of the test. Should it fail for whatever reason, that would indicate some 'break' due to ini settings, allowing the user as well as the developers (should a user submit a bug report) to determine if there is a problem and handle it accordingly.

I agree. We need real complex tests. However, I have different opinion. We do need complex tests, but we don't want to people tells us "Hey it does not work" merely slight ini setting difference _for_ run-tests.php.

Complex tests would be nice, but I doubt many admins would be willing to wait 10 or more minutes while a complex test suit runs. And given the fact the PHP

I don't get your point? Admins cannot spend 10 min to run test suit?

test suit had matured greatly, especially in 4.3.0 many admins may use it to determine if the compiled source is ready for 'prime time'.

IMO, admins that didn't test their own PHP script against newer PHP is not a professional. Anyway, run-tests.php runs well does not mean users script runs well. We don't need to test run-tests.php. Tests are done by phpt. In addition, run-tests.php is very biased test to be full test. Admins should test newer php with their scripts anyway. (If an admin want to be a professional admin :) -- Yasuo Ohgaki