Re: cvs: php4 /ext/domxml php_domxml.c

From: Date: Tue, 29 Oct 2002 17:06:14 +0000
Subject: Re: cvs: php4 /ext/domxml php_domxml.c
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-15603@lists.php.net to get a copy of this message
Confirms to CODING_STANDARDS. I only had to change the order. Perhaps we should rewrite that parg 9. [9] When commenting out code using a #if statement, do NOT use 0 only. Append
    to any 0 an _<cvs username here>.  For example, #if 0_FOO, where FOO is
    cvs user foo.  This allows easier tracking of why code was commented out,
    especially in bundled libraries.
marcus At 18:00 29.10.2002, Christian Stocker wrote:
hi excuse my ignorant question, but: @@ -740,6 +740,7 @@ } +#ifdef HELLY_0 is this intended? chregu static zval *xsltstylesheet_get_data(void *obj) { /* @@ -753,6 +754,7 @@ */
      return ((zval *) (((xsltStylesheetPtr) obj)->_private));
} +#endif void *php_xsltstylesheet_get_object(zval *wrapper, int rsrc_type1, int rsrc_type2 TSRMLS_DC) { @@ -3764,7 +3766,7 @@ PHP_FUNCTION(xmldoc) {
      zval *rv = NULL;
-     xmlDoc *docp;
+     xmlDoc *docp = NULL;
      int ret;
      char *buffer;
      int buffer_len;
@@ -3851,7 +3853,7 @@ PHP_FUNCTION(xmldocfile) {
      zval *rv = NULL;
-     xmlDoc *docp;
+     xmlDoc *docp = NULL;
      int ret, file_len;
      char *file;
      int mode = 0, prevSubstValue;
--
nam...christian stocker    adr...bremgartnerstr. 66, ch-8003 zurich
pho...+41  1 451 6021      www...http://phant.ch/chregu
mob...+41 76 561 8860      ema...chregu@phant.ch
wor...+41  1 240 5670      gpg...0x5CE1DECB
-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php


« previous php.cvs (#15603) next »