Re: cvs: php4 /ext/domxml php_domxml.c

From:	(Marcus Börger)	Date:	Tue, 29 Oct 2002 20:00:51 +0000
Subject:	Re: cvs: php4 /ext/domxml php_domxml.c
References:	1 2 3	Groups:	php.cvs
Request:	Send a blank email to php-cvs+get-15610@lists.php.net to get a copy of this message

At 18:48 29.10.2002, Derick Rethans wrote:

On Tue, 29 Oct 2002, Marcus Börger wrote: Confirms to CODING_STANDARDS. I only had to change the order. Perhaps we should rewrite that parg 9. [9] When commenting out code using a #if statement, do NOT use 0 only. Append
     to any 0 an _<cvs username here>.  For example, #if 0_FOO, where FOO is
     cvs user foo.  This allows easier tracking of why code was commented out,
     especially in bundled libraries.
Then you need to swap the 0 and HELLY in your code I think :)
+#ifdef HELLY_0

As i already wrote it fails with #ifdef 0_HELLY [marcus@zaphod php4-HEAD]$ make sapi/cli/php gcc -Iext/domxml/ -I/usr/src/php4-HEAD/ext/domxml/ [...] -o ext/domxml/php_domxml.o && echo > ext/domxml/php_domxml.lo /usr/src/php4-HEAD/ext/domxml/php_domxml.c:743:8: macro names must be identifiers make: *** [ext/domxml/php_domxml.lo] Error 1 [marcus@zaphod php4-HEAD]$ So again i think we should rewrite paragraph 9 of CODING_STANDARDS. marcus