Re: cvs: php4 /ext/openssl xp_ssl.c /main/streams xp_socket.c
| From: | Jon Parise | Date: | Tue, 18 Mar 2003 19:34:33 +0000 |
| Subject: | Re: cvs: php4 /ext/openssl xp_ssl.c /main/streams xp_socket.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-19672@lists.php.net to get a copy of this message | ||
On Tue, Mar 18, 2003 at 03:15:10PM -0000, Wez Furlong wrote:
> wez Tue Mar 18 10:15:10 2003 EDT
>
> Modified files:
> /php4/ext/openssl xp_ssl.c
> /php4/main/streams xp_socket.c
> Log:
> avoid unsigned issues.
[...]
> - if (didwrite > 0)
> + if (didwrite > 0) {
> php_stream_notify_progress_increment(stream->context, didwrite, 0);
> + }
>
> + if (didwrite < 0) {
> + didwrite = 0;
> + }
[...]
> + if (nr_bytes > 0) {
> php_stream_notify_progress_increment(stream->context, nr_bytes, 0);
> + }
> +
> + if (nr_bytes < 0) {
> + nr_bytes = 0;
> + }
[...]
> + if (nr_bytes > 0) {
> php_stream_notify_progress_increment(stream->context, nr_bytes, 0);
> + }
> +
> + if (nr_bytes < 0) {
> + nr_bytes = 0;
> + }
Would it be preferable to use 'else if's in these cases, instead?
if (nr_bytes > 0) {
php_stream_notify_progress_increment(stream->context, nr_bytes, 0);
} else if (nr_bytes < 0) {
nr_bytes = 0;
}
--
Jon Parise (jon@php.net) :: The PHP Project (http://www.php.net/)