Re: cvs: php4 /ext/openssl xp_ssl.c /main/streams xp_socket.c
| From: | Wez Furlong | Date: | Tue, 18 Mar 2003 21:14:36 +0000 |
| Subject: | Re: cvs: php4 /ext/openssl xp_ssl.c /main/streams xp_socket.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-19674@lists.php.net to get a copy of this message | ||
Possibly, although I plan to revise the notify_progress_increment()
stuff someday soon, so I'm happy to leave things as they are for the
moment.
--Wez.
On Tue, 18 Mar 2003, Jon Parise wrote:
> > - if (didwrite > 0)
> > + if (didwrite > 0) {
> > php_stream_notify_progress_increment(stream->context, didwrite, 0);
> > + }
> >
> > + if (didwrite < 0) {
> > + didwrite = 0;
> > + }
> Would it be preferable to use 'else if's in these cases, instead?
>
> if (nr_bytes > 0) {
> php_stream_notify_progress_increment(stream->context, nr_bytes, 0);
> } else if (nr_bytes < 0) {
> nr_bytes = 0;
> }