Re: cvs: php-src /win32 winutil.c
| From: | Marcus Boerger | Date: | Thu, 18 Dec 2003 11:47:05 +0000 |
| Subject: | Re: cvs: php-src /win32 winutil.c | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-25286@lists.php.net to get a copy of this message | ||
Hello Wez,
Thursday, December 18, 2003, 12:23:27 PM, you wrote:
> There is a deeper problem; this function is actually called
> from many win32 extensions where the result is correctly free'd,
> so we cannot use a static buffer here at all.
That is wrong behavior. The behavior of dl_error() has to reflect that of
the *nix implementation where it came from and there the buffer is allocated
and freed on the next call. Since also dl_error is only called in non
threaded environments my patch seemd the correct solution. If you now tell
that windows extensions free that pointer that is an error - not the
dl_error() patch.
marcus