Re: cvs: php-src /win32 winutil.c

This function is not used exclusively by dl_error; it is used in many places (network, com and other win32 extensions) to get a readable version of a win32 error code. --Wez. ----- Original Message ----- From: "Marcus Boerger" <helly@php.net> To: "Wez Furlong" <wez@thebrainroom.com> Cc: "Marcus Boerger" <helly@php.net>; <php-cvs@lists.php.net> Sent: Thursday, December 18, 2003 11:47 AM Subject: Re: [PHP-CVS] cvs: php-src /win32 winutil.c > Hello Wez, > > Thursday, December 18, 2003, 12:23:27 PM, you wrote: > > > There is a deeper problem; this function is actually called > > from many win32 extensions where the result is correctly free'd, > > so we cannot use a static buffer here at all. > > That is wrong behavior. The behavior of dl_error() has to reflect that of > the *nix implementation where it came from and there the buffer is allocated > and freed on the next call. Since also dl_error is only called in non > threaded environments my patch seemd the correct solution. If you now tell > that windows extensions free that pointer that is an error - not the > dl_error() patch. > > marcus > > >