Re: cvs: php-src /ext/xml compat.c expat_compat.h

> > > > 1) fix the code, so that it works with 2.5.x correctly as well > > > > 2) make 2.6.x a prerequisite > > > > 3) disable xml_parser_create_ns for 2.5.x > > > > 4) use broken code for 2.5.x and fixed code for 2.6.x > > > > 5) revert to yesterdays situation (broken for all...) > > > > I prefer 3. simply add some #id's and be done. If someone fixes it for > 2.5 > > > then solution 1) is pretty much nicer - but i doubt anybody has time for > > > that. > > > > > > > As far as I'm concerned 3 is not an option. We are not removing > > namespace support from PHP5 when PHP4 supports it. Broken in cases no > > one has reported is better than not supported at all. If libxml2.5 is > > supported there needs to be some sort of solution for namespaces, 1,2,4 > > and 5 are all fine by me; I prefer a combo of 1 and 4. > > It will never work correctly for option 1. Namespaces in SAX was a 2.6 thing > (SAX2). Right, but namespaces just need to work as good as they did in PHP4, we can't lose that compatibility. If it works better - bonus. > I dont like option 4 as if something is going to be implemented it should > work the same regardless of libxml version used (which is why I prefer 3 > over 4 - feature only available for 2.6.x and up). > It looks like the only thing everyone here can agree on then is make 2.6 > required and pray we are not introducing new problems. I prefer not to do > this, but it may be the only option that everyone can live with. > I'm fine with requiring 2.6, although things could blow up. -Sterling