Re: cvs: php-src /ext/xml compat.c expat_compat.h
| From: | Rob Richards | Date: | Mon, 23 Feb 2004 00:47:38 +0000 |
| Subject: | Re: cvs: php-src /ext/xml compat.c expat_compat.h | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-26335@lists.php.net to get a copy of this message | ||
> > It will never work correctly for option 1. Namespaces in SAX was a 2.6
thing
> > (SAX2).
>
> Right, but namespaces just need to work as good as they did in PHP4, we
> can't lose that compatibility. If it works better - bonus.
So what exactly is broken then in comparison to PHP4? From the size of the
patch and everything that was replaced, I was assuming quite a bit. And
looking at some of the functions added (start_element_ns, etc...) - those
are all SAX2 things. Are these needed to get it all working correctly or
were those just additional features? If that is the case, then I would
definitely agree fixing it for 2.5 is the way to go and not implement the
additional features - Arent we in a feature freeze anyways :)
> I'm fine with requiring 2.6, although things could blow up.
Right, that is what I am afraid of as well. As I mentioned I can live with
it, but prefer not to do this.