Re: cvs: php4 /ext/session session.c

From: Date: Sun, 19 Nov 2000 17:28:16 +0000
Subject: Re: cvs: php4 /ext/session session.c
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-2685@lists.php.net to get a copy of this message
> + is_ref = (*old_symbol)->is_ref; > + refcount = (*old_symbol)->refcount; > + **old_symbol = *state_val_copy; > + (*old_symbol)->is_ref = is_ref; > + (*old_symbol)->refcount = refcount; SS>> I think this kind of logic should be in Zend, and not in the SS>> extension code. While the task of changing an existing symbol SS>> might be complex, it should be simple for an extension to SS>> perform that step. You might be right, though Zend does not have such an opearion in it's API presently. So if somebody (Zeev, Andi?) can generalize this and add such an op to Zend, it would be good. Generally, what I need is to replace variable contents while preserving it's refcount and is_ref. BTW: we are going into Zend guts more or less anyway in serializing variables, it's inevitable. But I agree this code is ugly - it has to do ugly thing, so it is. -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.106

« previous php.cvs (#2685) next »