Re: cvs: php4 /ext/session session.c
| From: | Andi Gutmans | Date: | Sun, 19 Nov 2000 18:47:56 +0000 |
| Subject: | Re: cvs: php4 /ext/session session.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-2689@lists.php.net to get a copy of this message | ||
Yes, this is a nice idea.
Andi
At 18:21 19/11/00 +0100, Sascha Schumann wrote:
--- Andi Gutmans <andi@zend.com> http://www.zend.com/+ /* replace variable contents while saving is_ref and reference + count */ + is_ref = (*old_symbol)->is_ref; + refcount = (*old_symbol)->refcount; + **old_symbol = *state_val_copy; + (*old_symbol)->is_ref = is_ref; + (*old_symbol)->refcount = refcount;I think this kind of logic should be in Zend, and not in the extension code. While the task of changing an existing symbol might be complex, it should be simple for an extension to perform that step.- Sascha-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net For additional commands, e-mail: php-cvs-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net