Re: cvs: php4 /ext/dba dba.c

Hi, > Shoudn't the string be ended with '\0' ?? Yes, in the course of improving that another possible segfault was eliminated. > And should these smart_str_*() funcs be used always instead > of strcat() and friends? Well, as far as I am concerned, I recommened whatever is necessary to write flexible and save code. If the smart_str family of functions does that in your case, using them is certainly right. > There seems to be strcat() used also in ext/db/db.c for same > purpose. Shouldn't it be 'smart_str'ed' too? ext/db/* is dead. It provides a subset of functionality of dba (excluding flatfile and NFS hack). IMO it should be marked as deprecated and be removed down the road. - Sascha