Re: cvs: php4 /ext/dba dba.c

On Mon, 4 Dec 2000, Sascha Schumann wrote: >> And should these smart_str_*() funcs be used always instead >> of strcat() and friends? > > Well, as far as I am concerned, I recommened whatever is > necessary to write flexible and save code. If the smart_str > family of functions does that in your case, using them is > certainly right. These aren't documented anywhere? apidoc.txt maybe? Which reminds me that it should be either removed or updated. It's a bit outdated now.. >> There seems to be strcat() used also in ext/db/db.c for same >> purpose. Shouldn't it be 'smart_str'ed' too? > > ext/db/* is dead. It provides a subset of functionality of > dba (excluding flatfile and NFS hack). IMO it should be > marked as deprecated and be removed down the road. I did add 'deprecated' to the configure option when I made it not to be enabled by default. So it can be said to everyone using it that they shouldn't use it but move to dba instead? So I can close those db related bug reports..? But does the dba-extension provide all the functionality which db provides? At least reading the manual give such impression that it doesn't..(I haven't used either of these myself before) --Jani