Re: cvs: php-src(PHP_5_1) /ext/xmlreader php_xmlreader.c

Hello Pierre, this is actually a bug fix not a feature change or whatever. if you do '$reader->getAttribute($name) you right now have no way of figuring out whether the attribute is empty or does not exist. I found that out while doing my slides on xmlReader over the weekend. We discussed it here in Montreal and all agreed that NULL is the best option since in contrast to false it also allows to use isset() and empty() on the return value. regards marcus Thursday, March 30, 2006, 7:42:11 PM, you wrote: > On 3/30/06, Lukas Kahwe Smith <mls@pooteeweet.org> wrote: >> Marcus Boerger wrote: >> > helly Thu Mar 30 17:37:50 2006 UTC >> > >> > Modified files: (Branch: PHP_5_1) >> > /php-src/ext/xmlreader php_xmlreader.c >> > Log: >> > - MFH Return NULL instead of '' if node does not exist >> >> dont you think this could cause issues for people .. maybe wait for 5.2? > It will as soon as someone uses ==='', I agree that should not be > changed in a bug fix release. > --Pierre . Best regards, Marcus