Re: cvs: php-src(PHP_5_1) /ext/xmlreader php_xmlreader.c

Hello Hannes, Thursday, March 30, 2006, 9:26:27 PM, you wrote: > On 3/30/06, Marcus Boerger <helly@php.net> wrote: >> Hello Pierre, >> >> this is actually a bug fix not a feature change or whatever. >> if you do '$reader->getAttribute($name) you right now have no way of >> figuring out whether the attribute is empty or does not exist. I >> found that out while doing my slides on xmlReader over the weekend. >> We discussed it here in Montreal and all agreed that NULL is the best >> option since in contrast to false it also allows to use isset() and >> empty() on the return value. > Returning "" is however compatible with DOMElement->getAttribute()... If that is the case then it is an error there, too. I must admit i never use DOM so i don't know and don't care either. Best regards, Marcus