Re: cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c
| From: | Andi Gutmans | Date: | Wed, 14 Jun 2006 17:02:28 +0000 |
| Subject: | Re: cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c | ||
| References: | 1 2 3 4 5 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-38723@lists.php.net to get a copy of this message | ||
I definitely think we should stick to our standard with no exceptions. We have suffered from inconsistencies forever.
str_transliterate() sounds good to me.
Andi
At 12:10 AM 6/14/2006, Andrei Zmievski wrote:
Yes, I know. But I don't think anything other than transliterate() makes sense. text_transliterate()? str_transliterate()? We've abandoned the idea of i18n_ prefix and unicode_ doesn't fit here either.. -Andrei On Jun 13, 2006, at 8:41 PM, Andi Gutmans wrote:As you know our naming conventions are module_function, e.g. unicode_transliterate, i18n_transliterate, char_transliterate. Don't know what is suitable here but for the past couple of years we have started enforcing that in all new functions to PHP. See "Naming Conventions" in CODING_STANDARDS. Thx. At 07:49 PM 6/13/2006, Andrei Zmievski wrote:-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.phpWhat do you mean? -Andrei On Jun 13, 2006, at 5:45 PM, Andi Gutmans wrote:Please fix the naming conventions...-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php