Re: cvs: php-src /ext/sqlite sqlite.c
| From: | Marcus Boerger | Date: | Wed, 14 Jun 2006 17:07:15 +0000 |
| Subject: | Re: cvs: php-src /ext/sqlite sqlite.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-38724@lists.php.net to get a copy of this message | ||
Hello Ilia,
why change this to a recoveranle here? This messages states that you are
doing somethign worng syntax wise. That should be a fatal error and is a
fatal error in all other iterator implementations.
best regards
marcus
Wednesday, June 14, 2006, 6:04:47 PM, you wrote:
> iliaa Wed Jun 14 16:04:47 2006 UTC
> Modified files:
> /php-src/ext/sqlite sqlite.c
> Log:
> MFB: E_ERROR -> E_RECOVERABLE_ERROR
>
>
>
> http://cvs.php.net/viewcvs.cgi/php-src/ext/sqlite/sqlite.c?r1=1.193&r2=1.194&diff_format=u
> Index: php-src/ext/sqlite/sqlite.c
> diff -u php-src/ext/sqlite/sqlite.c:1.193 php-src/ext/sqlite/sqlite.c:1.194
> --- php-src/ext/sqlite/sqlite.c:1.193 Tue Jun 13 13:12:19 2006
> +++ php-src/ext/sqlite/sqlite.c Wed Jun 14 16:04:47 2006
> @@ -17,7 +17,7 @@
> | Marcus Boerger <helly@php.net> |
> +----------------------------------------------------------------------+
>
> - $Id: sqlite.c,v 1.193 2006/06/13 13:12:19 dmitry Exp $
> + $Id: sqlite.c,v 1.194 2006/06/14 16:04:47 iliaa Exp $
> */
>
> #ifdef HAVE_CONFIG_H
> @@ -1007,7 +1007,7 @@
> sqlite_object *obj = (sqlite_object*)
> zend_object_store_get_object(object TSRMLS_CC);
>
> if (by_ref) {
> - zend_error(E_ERROR, "An iterator cannot be used with foreach by
> reference");
> + zend_error(E_RECOVERABLE_ERROR, "An iterator cannot be used with foreach
> by reference");
> }
>
> iterator = emalloc(sizeof(sqlite_object_iterator));
> @@ -1129,7 +1129,7 @@
> {
> php_info_print_table_start();
> php_info_print_table_header(2, "SQLite support", "enabled");
> - php_info_print_table_row(2, "PECL Module version",
> PHP_SQLITE_MODULE_VERSION " $Id: sqlite.c,v 1.193 2006/06/13 13:12:19 dmitry Exp $");
> + php_info_print_table_row(2, "PECL Module version",
> PHP_SQLITE_MODULE_VERSION " $Id: sqlite.c,v 1.194 2006/06/14 16:04:47 iliaa Exp $");
> php_info_print_table_row(2, "SQLite Library", sqlite_libversion());
> php_info_print_table_row(2, "SQLite Encoding", sqlite_libencoding());
> php_info_print_table_end();
Best regards,
Marcus