Re: cvs: php-src(PHP_5_2) /ext/dom element.c /ext/dom/tests bug38949.phpt nsdoc.xml

On 27.09.2006 14:31, Rob Richards wrote:

rrichards Wed Sep 27 10:31:24 2006 UTC

  Added files:                 (Branch: PHP_5_2)
    /php-src/ext/dom/tests	bug38949.phpt nsdoc.xml 
  Modified files:                  /php-src/ext/dom	element.c   Log:

fix bug #38949 (Cannot get xmlns value attribute) add test

@@ -275,16 +302,30 @@ } attr = dom_get_dom1_attribute(nodep, (xmlChar *)name); - if (attr != NULL && attr->type != XML_ATTRIBUTE_DECL) { + if (attr != NULL) { + switch (attr->type) { + case XML_ATTRIBUTE_NODE: node_list_unlink(attr->children TSRMLS_CC); + break; + case XML_NAMESPACE_DECL: + RETURN_FALSE; + } + + }

No default action ? I get lots of warnings because of that: /local/dev/php-src_5_2/ext/dom/element.c: In function `zif_dom_element_set_attribute': /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_ELEMENT_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_TEXT_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_CDATA_SECTION_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_ENTITY_REF_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_ENTITY_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_PI_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_COMMENT_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_DOCUMENT_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_DOCUMENT_TYPE_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_DOCUMENT_FRAG_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_NOTATION_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_HTML_DOCUMENT_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_DTD_NODE' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_ELEMENT_DECL' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_ATTRIBUTE_DECL' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_ENTITY_DECL' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_XINCLUDE_START' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_XINCLUDE_END' not handled in switch /local/dev/php-src_5_2/ext/dom/element.c:312: warning: enumeration value `XML_DOCB_DOCUMENT_NODE' not handled in switch -- Wbr, Antony Dovgal