Re: cvs: php-src(PHP_5_2) /ext/dom element.c /ext/dom/tests bug38949.phpt nsdoc.xml

From:	Rob Richards	Date:	Wed, 27 Sep 2006 17:25:37 +0000
Subject:	Re: cvs: php-src(PHP_5_2) /ext/dom element.c /ext/dom/tests bug38949.phpt nsdoc.xml
References:	1 2	Groups:	php.cvs
Request:	Send a blank email to php-cvs+get-40727@lists.php.net to get a copy of this message

Antony Dovgal wrote:

On 27.09.2006 14:31, Rob Richards wrote:

     attr = dom_get_dom1_attribute(nodep, (xmlChar *)name);
-    if (attr != NULL && attr->type != XML_ATTRIBUTE_DECL) {
+    if (attr != NULL) {
+        switch (attr->type) {
+            case XML_ATTRIBUTE_NODE:
         node_list_unlink(attr->children TSRMLS_CC);
+                break;
+            case XML_NAMESPACE_DECL:
+                RETURN_FALSE;
+        }

+    }

No default action ?

Nope. I wont get a chance to change it till tomorrow, so can you either add a default doing nothing or if/else that? Rob