Re: cvs: php-src /ext/mcrypt/tests bug41252.phpt
| From: | Derick Rethans | Date: | Thu, 19 Jul 2007 15:26:53 +0000 |
| Subject: | Re: cvs: php-src /ext/mcrypt/tests bug41252.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-45462@lists.php.net to get a copy of this message | ||
On Thu, 19 Jul 2007, Antony Dovgal wrote:
> tony2001 Thu Jul 19 14:35:45 2007 UTC
>
> Modified files:
> /php-src/ext/mcrypt/tests bug41252.phpt
> Log:
> fix test
>
>
>
> http://cvs.php.net/viewvc.cgi/php-src/ext/mcrypt/tests/bug41252.phpt?r1=1.1&r2=1.2&diff_format=u
> Index: php-src/ext/mcrypt/tests/bug41252.phpt
> diff -u php-src/ext/mcrypt/tests/bug41252.phpt:1.1 php-src/ext/mcrypt/tests/bug41252.phpt:1.2
> --- php-src/ext/mcrypt/tests/bug41252.phpt:1.1 Tue May 1 16:04:16 2007
> +++ php-src/ext/mcrypt/tests/bug41252.phpt Thu Jul 19 14:35:45 2007
> @@ -4,10 +4,10 @@
> <?php if (!extension_loaded("mcrypt")) print "skip"; ?>
> --FILE--
> <?php
> -$td = mcrypt_module_open(MCRYPT_DES, '', MCRYPT_MODE_ECB, '');
> +$td = mcrypt_module_open(MCRYPT_DES, b'', MCRYPT_MODE_ECB, b'');
That doesn't look right, these two parameters are directory names and
they could just as well be in unicode. They should use the
filename_encoding setting to convert from Unicode to the filesystem
encoding - not just binary strings.
Derick