Re: cvs: php-src /ext/mcrypt/tests bug41252.phpt

On Thu, 19 Jul 2007, Antony Dovgal wrote: > On 19.07.2007 19:26, Derick Rethans wrote: > > > -$td = mcrypt_module_open(MCRYPT_DES, '', MCRYPT_MODE_ECB, ''); > > > +$td = mcrypt_module_open(MCRYPT_DES, b'', MCRYPT_MODE_ECB, b''); > > > > That doesn't look right, these two parameters are directory names and they > > could just as well be in unicode. They should use the filename_encoding > > setting to convert from Unicode to the filesystem encoding - not just binary > > strings. > > Then there is something wrong with the code, since I got "expected > strictly binary string, got Unicode string instead" warning. Dmitry upgraded it, but not 100% correct then. I'd say we revert the change you made to the test so we won't forget about it. (Feel free to assign a bug to me about it). Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org