Re: cvs: php-src(PHP_5_2) /ext/mysql php_mysql.c
| From: | Johannes Schlüter | Date: | Tue, 12 Feb 2008 20:49:53 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) /ext/mysql php_mysql.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-48491@lists.php.net to get a copy of this message | ||
Hi,
On Tue, 2008-02-12 at 20:04 +0100, "Hannes Magnusson" wrote:
> > @@ -556,7 +556,7 @@
> > hashed_details_length = spprintf(&hashed_details, 0,
> > "mysql__%s_", user);
> > client_flags = CLIENT_INTERACTIVE;
> > } else {
> > - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
> > "|s!s!s!ll", &host_and_port, &host_len,
> > + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
> > "|s!s!s!bl", &host_and_port, &host_len,
> > &user,
> > &user_len, &passwd, &passwd_len,
> > &new_link,
> > &client_flags)==FAILURE) {
> > return;
>
> Won't this break the client_flags parameter for mysql_pconnect()?
I've just committed a fix which should make the code better readable in
this place to avoid similar problems in the future.
johannes